Messages in this thread | | | Subject | Re: [PATCH] pnp: isapnp: make core more explicitly non-modular | From | Jaroslav Kysela <> | Date | Tue, 16 Aug 2016 07:56:37 +0200 |
| |
Dne 16.8.2016 v 00:42 Paul Gortmaker napsal(a): > The Makefile currently controlling compilation of this code is: > > obj-y += pnp.o > pnp-y := core.o compat.o > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the couple traces of modular infrastructure use, so that > when reading the driver there is no doubt it is builtin-only. > > Also note that MODULE_DEVICE_TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > We don't replace module.h with init.h since the file already has that. > But we do add moduleparam.h since the file does use module_param(). > > Cc: Jaroslav Kysela <perex@perex.cz> > Cc: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com> > Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
Acked-by: Jaroslav Kysela <perex@perex.cz>
-- Jaroslav Kysela <perex@perex.cz> Linux Sound Maintainer; ALSA Project; Red Hat, Inc.
| |