Messages in this thread | | | Date | Tue, 16 Aug 2016 12:03:14 +0900 | From | Joonsoo Kim <> | Subject | Re: [PATCH v2] mm/slab: Improve performance of gathering slabinfo stats |
| |
On Fri, Aug 05, 2016 at 09:21:56AM -0500, Christoph Lameter wrote: > On Fri, 5 Aug 2016, Joonsoo Kim wrote: > > > If above my comments are fixed, all counting would be done with > > holding a lock. So, atomic definition isn't needed for the SLAB. > > Ditto for slub. struct kmem_cache_node is alrady defined in mm/slab.h. > Thus it is a common definition already and can be used by both. > > Making nr_slabs and total_objects unsigned long would be great.
In SLUB, nr_slabs is manipulated without holding a lock so atomic operation should be used.
Anyway, Aruna. Could you handle my comment?
Thank.
| |