Messages in this thread | | | From | Haiyang Zhang <> | Subject | RE: [PATCH net v2 5/5] hv_netvsc: fix bonding devices check in netvsc_netdev_event() | Date | Mon, 15 Aug 2016 15:54:55 +0000 |
| |
> -----Original Message----- > From: Vitaly Kuznetsov [mailto:vkuznets@redhat.com] > Sent: Monday, August 15, 2016 11:49 AM > To: netdev@vger.kernel.org > Cc: devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; Haiyang > Zhang <haiyangz@microsoft.com>; KY Srinivasan <kys@microsoft.com>; > Stephen Hemminger <stephen@networkplumber.org> > Subject: [PATCH net v2 5/5] hv_netvsc: fix bonding devices check in > netvsc_netdev_event() > > Bonding driver sets IFF_BONDING on both master (the bonding device) and > slave (the real NIC) devices and in netvsc_netdev_event() we want to skip > master devices only. Currently, there is an uncertainty when a slave > interface is removed: if bonding module comes first in netdev_chain it > clears IFF_BONDING flag on the netdev and netvsc_netdev_event() > correctly > handles NETDEV_UNREGISTER event, but in case netvsc comes first on the > chain it sees the device with IFF_BONDING still attached and skips it. As > we still hold vf_netdev pointer to the device we crash on the next inject. > > Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
Thanks!
Acked-by: Haiyang Zhang <haiyangz@microsoft.com>
| |