Messages in this thread | | | Date | Mon, 15 Aug 2016 16:48:30 +0200 | From | Greg KH <> | Subject | Re: [PATCH] Staging: android: ion: ion.c: Compression of lines for |
| |
On Tue, Aug 02, 2016 at 11:13:20AM -0700, Nadim almas wrote: > This patch compresses two lines in to a single line in file > ion.c > if immediate return statement is found.It also removes variable > ret as it is no longer needed. > > ne using script Coccinelle. And coccinelle uses following semantic > patch for this compression function: > > @@ > expression e, ret; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-by: Nadim Almas <nadim.902@gmail.com> > --- > drivers/staging/android/ion/ion.c | 8 +++----- > > 1 files changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/android/ion/ion.c b/drivers/staging/android/ion/ion.c > index 52345df..271395b 100644 > --- a/drivers/staging/android/ion/ion.c > +++ b/drivers/staging/android/ion/ion.c > @@ -391,9 +391,7 @@ static int ion_handle_put_nolock(struct ion_handle *handle) > { > - int ret; > > - ret = kref_put(&handle->ref, ion_handle_destroy); > - > - return ret; > + return kref_put(&handle->ref, ion_handle_destroy); > } > > static int ion_handle_put(struct ion_handle *handle) > @@ -597,8 +595,8 @@ int ion_phys(struct ion_client *client, struct ion_handle *handle, > return -ENODEV; > } > mutex_unlock(&client->lock); > - ret = buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > - return ret; > + return buffer->heap->ops->phys(buffer->heap, buffer, addr, len); > } > EXPORT_SYMBOL(ion_phys);
Patch is malformed and can not be applied :(
| |