Messages in this thread | | | Date | Mon, 15 Aug 2016 00:19:33 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH v2] eeprom: at24: check if the chip is functional in probe() |
| |
On Fri, Aug 12, 2016 at 01:32:57PM +0200, Bartosz Golaszewski wrote: > The at24 driver doesn't check if the chip is functional in its probe > function. This leads to instantiating devices that are not physically > present. For example the cape EEPROMs for BeagleBone Black are defined > in the device tree at four addresses on i2c2, but normally only one of > them is present. > > If the userspace doesn't know the location in advance, it will need to > check if reading the nvmem attributes fails to determine which EEPROM > is actually there. > > Try to read a single byte in probe() and bail-out with -ENODEV if the > read fails. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Applied to for-next, thanks!
[unhandled content-type:application/pgp-signature] | |