lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] CodingStyle: Clarify and complete chapter 7
On Sun, 14 Aug 2016 13:12:33 -0700
Mark D Rustad <mrustad@gmail.com> wrote:

> >> + err:
> >> kfree(foo->bar);
> >> kfree(foo);
> >> return ret;
> >>
> >> The bug in this code is that on some exit paths "foo" is NULL. Normally the
> >
> > ...except that kfree() can handle null pointers just fine, so this isn't
> > actually a bug, right? Someday when somebody has time it would be good to
> > come up with a better example.
>
> But if foo is NULL, foo->bar is not NULL and so kfree will have a problem
> with it. So this is a bug.

Oops, sigh, duh. OK, ignore me. (Though technically kfree will not have a
problem with it, since things won't get that far.. :)

jon

\
 
 \ /
  Last update: 2016-09-17 09:56    [W:0.728 / U:0.036 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site