lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 273/305] ALSA: compress: fix an integer overflow check
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Dan Carpenter <dan.carpenter@oracle.com>

    commit 6217e5ede23285ddfee10d2e4ba0cc2d4c046205 upstream.

    I previously added an integer overflow check here but looking at it now,
    it's still buggy.

    The bug happens in snd_compr_allocate_buffer(). We multiply
    ".fragments" and ".fragment_size" and that doesn't overflow but then we
    save it in an unsigned int so it truncates the high bits away and we
    allocate a smaller than expected size.

    Fixes: b35cc8225845 ('ALSA: compress_core: integer overflow in snd_compr_allocate_buffer()')
    Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/core/compress_offload.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/sound/core/compress_offload.c
    +++ b/sound/core/compress_offload.c
    @@ -500,7 +500,7 @@ static int snd_compress_check_input(stru
    {
    /* first let's check the buffer parameter's */
    if (params->buffer.fragment_size == 0 ||
    - params->buffer.fragments > SIZE_MAX / params->buffer.fragment_size)
    + params->buffer.fragments > INT_MAX / params->buffer.fragment_size)
    return -EINVAL;

    /* now codec parameters */
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.092 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site