lkml.org 
[lkml]   [2016]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 244/305] net: bgmac: Remove superflous netif_carrier_on()
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Florian Fainelli <f.fainelli@gmail.com>

    commit 3894396e64994f31c3ef5c7e6f63dded0593e567 upstream.

    bgmac_open() calls phy_start() to initialize the PHY state machine,
    which will set the interface's carrier state accordingly, no need to
    force that as this could be conflicting with the PHY state determined by
    PHYLIB.

    Fixes: dd4544f05469 ("bgmac: driver for GBit MAC core on BCMA bus")
    Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/net/ethernet/broadcom/bgmac.c | 2 --
    1 file changed, 2 deletions(-)

    --- a/drivers/net/ethernet/broadcom/bgmac.c
    +++ b/drivers/net/ethernet/broadcom/bgmac.c
    @@ -1198,8 +1198,6 @@ static int bgmac_open(struct net_device

    phy_start(bgmac->phy_dev);

    - netif_carrier_on(net_dev);
    -
    netif_start_queue(net_dev);

    err_out:
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.123 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site