lkml.org 
[lkml]   [2016]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 281/305] rds: fix an infoleak in rds_inc_info_copy
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kangjie Lu <kangjielu@gmail.com>

    commit 4116def2337991b39919f3b448326e21c40e0dbb upstream.

    The last field "flags" of object "minfo" is not initialized.
    Copying this object out may leak kernel stack data.
    Assign 0 to it to avoid leak.

    Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
    Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    net/rds/recv.c | 2 ++
    1 file changed, 2 insertions(+)

    --- a/net/rds/recv.c
    +++ b/net/rds/recv.c
    @@ -543,5 +543,7 @@ void rds_inc_info_copy(struct rds_incomi
    minfo.fport = inc->i_hdr.h_dport;
    }

    + minfo.flags = 0;
    +
    rds_info_copy(iter, &minfo, sizeof(minfo));
    }
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.068 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site