lkml.org 
[lkml]   [2016]   [Aug]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 277/305] ALSA: timer: Fix leak in SNDRV_TIMER_IOCTL_PARAMS
    3.16.37-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Kangjie Lu <kangjielu@gmail.com>

    commit cec8f96e49d9be372fdb0c3836dcf31ec71e457e upstream.

    The stack object “tread” has a total size of 32 bytes. Its field
    “event” and “val” both contain 4 bytes padding. These 8 bytes
    padding bytes are sent to user without being initialized.

    Signed-off-by: Kangjie Lu <kjlu@gatech.edu>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    sound/core/timer.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/sound/core/timer.c
    +++ b/sound/core/timer.c
    @@ -1750,6 +1750,7 @@ static int snd_timer_user_params(struct
    if (tu->timeri->flags & SNDRV_TIMER_IFLG_EARLY_EVENT) {
    if (tu->tread) {
    struct snd_timer_tread tread;
    + memset(&tread, 0, sizeof(tread));
    tread.event = SNDRV_TIMER_EVENT_EARLY;
    tread.tstamp.tv_sec = 0;
    tread.tstamp.tv_nsec = 0;
    \
     
     \ /
      Last update: 2016-09-17 09:56    [W:4.134 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site