Messages in this thread | | | Subject | Re: [PATCH 2/2 v3] be2iscsi: Fix some error messages | From | Joe Perches <> | Date | Sat, 13 Aug 2016 09:41:38 -0700 |
| |
On Sat, 2016-08-13 at 14:31 +0200, Christophe JAILLET wrote: > Le 13/08/2016 à 13:35, Joe Perches a écrit : > > > @@ -268,7 +268,7 @@ static int beiscsi_eh_abort(struct scsi_cmnd *sc) > > > &nonemb_cmd.dma); > > > if (nonemb_cmd.va == NULL) { > > > beiscsi_log(phba, KERN_ERR, BEISCSI_LOG_EH, > > > - "BM_%d : Failed to allocate memory for" > > > + "BM_%d : Failed to allocate memory for " > > > "mgmt_invalidate_icds\n"); > > doesn't match commit log as no coalescing/concatenation > > is done. > > > > There are many of these. > > > I have *only* fixed the one reported by checkpatch and left the others > unchanged. > > My initial proposal was to fix incorrect strings, without modifying too > much the code. So I decided to do the minimum of changes. > > Should I resubmitted with: > - all strings *in the patch* concatenated? > - all strings *in the file*" concatenated?
Hello Christophe
You don't _have_ to do anything.
I think the commit message is misleading.
You could submit another patch that does the equivalent of:
$ ./scripts/checkpatch.pl --types=SPLIT_STRING --fix-inplace drivers/scsi/be2iscsi/be_main.c
with the appropriate commit message
| |