Messages in this thread Patch in this message | | | Subject | [PATCH 06/18] autofs - remove ino free in autofs4_dir_symlink() | From | Ian Kent <> | Date | Fri, 12 Aug 2016 10:48:00 +0800 |
| |
The inode allocation failure case in autofs4_dir_symlink() frees the autofs dentry info of the dentry without setting ->d_fsdata to NULL.
That could lead to a double free so just get rid of the free and leave it to ->d_release().
Signed-off-by: Ian Kent <raven@themaw.net> Cc: Tomohiro Kusumi <kusumi.tomohiro@gmail.com> --- fs/autofs4/root.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c index fa84bb8..1b0495a 100644 --- a/fs/autofs4/root.c +++ b/fs/autofs4/root.c @@ -577,8 +577,6 @@ static int autofs4_dir_symlink(struct inode *dir, inode = autofs4_get_inode(dir->i_sb, S_IFLNK | 0555); if (!inode) { kfree(cp); - if (!dentry->d_fsdata) - kfree(ino); return -ENOMEM; } inode->i_private = cp;
| |