Messages in this thread | | | Date | Thu, 11 Aug 2016 15:42:57 +0200 | From | Alexandre Belloni <> | Subject | Re: [PATCH v2 1/2] rtc: bq32k: Use correct mask name for 'minutes' register. |
| |
On 11/08/2016 at 13:31:43 +0200, Daniel Romell wrote : > From: Jan Östlund <jao@hms.se> > > The BQ32K_SECONDS_MASK and BQ32K_MINUTES_MASK both has the same > value. This is no functional change. > > Signed-off-by: Daniel Romell <daro@hms.se>
Sorry, I saw it only before trying apply but both patches also need Jan's SoB.
> --- > drivers/rtc/rtc-bq32k.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-bq32k.c b/drivers/rtc/rtc-bq32k.c > index 0299988..5a0c137 100644 > --- a/drivers/rtc/rtc-bq32k.c > +++ b/drivers/rtc/rtc-bq32k.c > @@ -94,7 +94,7 @@ static int bq32k_rtc_read_time(struct device *dev, struct rtc_time *tm) > return error; > > tm->tm_sec = bcd2bin(regs.seconds & BQ32K_SECONDS_MASK); > - tm->tm_min = bcd2bin(regs.minutes & BQ32K_SECONDS_MASK); > + tm->tm_min = bcd2bin(regs.minutes & BQ32K_MINUTES_MASK); > tm->tm_hour = bcd2bin(regs.cent_hours & BQ32K_HOURS_MASK); > tm->tm_mday = bcd2bin(regs.date); > tm->tm_wday = bcd2bin(regs.day) - 1; > -- > 2.7.4 >
-- Alexandre Belloni, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com
| |