lkml.org 
[lkml]   [2016]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/4] gpio: Add AXP209 GPIO driver
On Wed, Jul 20, 2016 at 4:11 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:

> The AXP209 PMIC has a bunch of GPIOs accessible, that are usually used to
> control LEDs or backlight.
>
> Add a driver for them
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Acked-by: Rob Herring <robh@kernel.org>

Patch applied, it's clean and simple. I would suggest the
following immediate improvement (send separate patch):

Add a .get_direction() callback, I have started to push this
for new driver as it gives better userspace experience
and overall better control of stuff.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2016-08-11 11:01    [W:0.068 / U:0.668 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site