lkml.org 
[lkml]   [2016]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 1/3] drm: bridge: add DesignWare HDMI I2S audio support
Date

Hi Russell

> > +static int snd_dw_hdmi_probe(struct platform_device *pdev)
> > +{
> > + struct dw_hdmi_i2s_audio_data *audio = pdev->dev.platform_data;
> > + struct platform_device_info pdevinfo;
> > + struct hdmi_codec_pdata pdata;
> > +
> > + pdata.ops = &dw_hdmi_i2s_ops;
> > + pdata.i2s = 1;
> > + pdata.max_i2s_channels = 6;
> > + pdata.data = audio;
> > +
> > + memset(&pdevinfo, 0, sizeof(pdevinfo));
> > + pdevinfo.parent = pdev->dev.parent;
> > + pdevinfo.id = PLATFORM_DEVID_AUTO;
> > + pdevinfo.name = HDMI_CODEC_DRV_NAME;
> > + pdevinfo.data = &pdata;
> > + pdevinfo.size_data = sizeof(pdata);
> > + pdevinfo.dma_mask = DMA_BIT_MASK(32);
> > +
> > + return IS_ERR_OR_NULL(platform_device_register_full(&pdevinfo));
>
> This is certainly wrong. You're returning a 0/1 value rather than
> an error code when platform_device_register_full() fails.

Thanks.
I forgot why I added this ??
I will fix it on v2 patch

\
 
 \ /
  Last update: 2016-08-02 03:21    [W:0.131 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site