lkml.org 
[lkml]   [2016]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: xfs_icache.c:1298]: (style) Redundant condition
On Mon, Jul 25, 2016 at 04:13:28PM +0100, David Binderman wrote:
> Hello there,
>
> linux-4.7/fs/xfs/xfs_icache.c:1298]: (style) Redundant condition:
> eofb. '!eofb || (eofb && eofb.eof_scan_owner!=0)' is equivalent to
> '!eofb || eofb.eof_scan_owner!=0'
>
> Source code is
>
> ASSERT(!eofb || (eofb && eofb->eof_scan_owner != 0));
>
> Maybe better code
>
> ASSERT(!eofb || (eofb->eof_scan_owner != 0));

Yes, that would be better. But it's probably not worth changing
existing code just for that.

\
 
 \ /
  Last update: 2016-08-01 09:21    [W:0.044 / U:0.360 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site