lkml.org 
[lkml]   [2016]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: vmscan: fix memcg-aware shrinkers not called on global reclaim
    On Mon 01-08-16 16:03:10, Vladimir Davydov wrote:
    > We must call shrink_slab() for each memory cgroup on both global and
    > memcg reclaim in shrink_node_memcg(). Commit d71df22b55099 accidentally
    > changed that so that now shrink_slab() is only called with memcg != NULL
    > on memcg reclaim. As a result, memcg-aware shrinkers (including
    > dentry/inode) are never invoked on global reclaim. Fix that.
    >
    > Fixes: d71df22b55099 ("mm, vmscan: begin reclaiming pages on a per-node basis")

    I guess you meant b2e18757f2c9. I do not see d71df22b55099 anywhere.

    > Signed-off-by: Vladimir Davydov <vdavydov@virtuozzo.com>

    The fix looks ok to me otherwise

    Acked-by: Michal Hocko <mhocko@suse.com>

    > ---
    > mm/vmscan.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/mm/vmscan.c b/mm/vmscan.c
    > index 650d26832569..374d95d04178 100644
    > --- a/mm/vmscan.c
    > +++ b/mm/vmscan.c
    > @@ -2561,7 +2561,7 @@ static bool shrink_node(pg_data_t *pgdat, struct scan_control *sc)
    > shrink_node_memcg(pgdat, memcg, sc, &lru_pages);
    > node_lru_pages += lru_pages;
    >
    > - if (!global_reclaim(sc))
    > + if (memcg)
    > shrink_slab(sc->gfp_mask, pgdat->node_id,
    > memcg, sc->nr_scanned - scanned,
    > lru_pages);
    > --
    > 2.1.4
    >
    > --
    > To unsubscribe, send a message with 'unsubscribe linux-mm' in
    > the body to majordomo@kvack.org. For more info on Linux MM,
    > see: http://www.linux-mm.org/ .
    > Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

    --
    Michal Hocko
    SUSE Labs

    \
     
     \ /
      Last update: 2016-08-01 16:01    [W:2.378 / U:0.088 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site