lkml.org 
[lkml]   [2016]   [Aug]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] memory: omap-gpmc: Delete an unnecessary check before the function call "gpiochip_free_own_desc"
    From
    Date
    Hi Markus,

    On 23/07/16 20:09, SF Markus Elfring wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Sat, 23 Jul 2016 18:54:02 +0200
    >
    > The gpiochip_free_own_desc() function tests whether its argument is NULL
    > and then returns immediately. Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    > ---
    > drivers/memory/omap-gpmc.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/memory/omap-gpmc.c b/drivers/memory/omap-gpmc.c
    > index 869c83f..e138875 100644
    > --- a/drivers/memory/omap-gpmc.c
    > +++ b/drivers/memory/omap-gpmc.c
    > @@ -2143,9 +2143,7 @@ err_child_fail:
    > ret = -ENODEV;
    >
    > err_cs:
    > - if (waitpin_desc)
    > - gpiochip_free_own_desc(waitpin_desc);
    > -
    > + gpiochip_free_own_desc(waitpin_desc);
    > err:
    > gpmc_cs_free(cs);
    >
    >
    This looks good to me. I will queue this for v4.8. Thanks.

    cheers,
    -roger

    \
     
     \ /
      Last update: 2016-08-01 12:01    [W:4.306 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site