Messages in this thread | | | Date | Fri, 8 Jul 2016 17:20:37 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH] [RFC V1]s390/perf: fix 'start' address of module's map |
| |
On Fri, Jul 08, 2016 at 10:17:30AM +0800, Songshan Gong wrote:
SNIP
> > diff --git a/tools/perf/util/machine.c b/tools/perf/util/machine.c > > index b177218..e5c2721 100644 > > --- a/tools/perf/util/machine.c > > +++ b/tools/perf/util/machine.c > > @@ -1091,12 +1091,18 @@ static int machine__set_modules_path(struct machine *machine) > > > > return map_groups__set_modules_path_dir(&machine->kmaps, modules_path, 0); > > } > > +int __weak arch__fix_module_baseaddr(struct machine *machine __maybe_unused, > > + u64 *start __maybe_unused, const char *name __maybe_unused) > > +{ > > + return 0; > > +} > > > > static int machine__create_module(void *arg, const char *name, u64 start) > > { > > struct machine *machine = arg; > > struct map *map; > > > > + arch__fix_module_baseaddr(machine, &start, name); > > As the description says, I would change the function name to > 'arch__fix_module_text_start';
both of them sound good to me
jirka
| |