lkml.org 
[lkml]   [2016]   [Jul]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH v2 1/4] xenbus: prefer xenbus_scanf() over xenbus_gather()
    For single items being collected this should be preferred as being more
    typesafe (as the compiler can check format string and to-be-written-to
    variable match) and more efficient (requiring one less parameter to be
    passed).

    Signed-off-by: Jan Beulich <jbeulich@suse.com>
    ---
    v2: Avoid commit message to continue from subject.
    ---
    drivers/xen/xenbus/xenbus_client.c | 6 +++---
    1 file changed, 3 insertions(+), 3 deletions(-)

    --- 4.7-rc6-prefer-xenbus_scanf.orig/drivers/xen/xenbus/xenbus_client.c
    +++ 4.7-rc6-prefer-xenbus_scanf/drivers/xen/xenbus/xenbus_client.c
    @@ -926,9 +926,9 @@ EXPORT_SYMBOL_GPL(xenbus_unmap_ring);
    */
    enum xenbus_state xenbus_read_driver_state(const char *path)
    {
    - enum xenbus_state result;
    - int err = xenbus_gather(XBT_NIL, path, "state", "%d", &result, NULL);
    - if (err)
    + int result;
    +
    + if (xenbus_scanf(XBT_NIL, path, "state", "%d", &result) != 1)
    result = XenbusStateUnknown;

    return result;


    \
     
     \ /
      Last update: 2016-07-08 15:01    [W:2.516 / U:1.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site