lkml.org 
[lkml]   [2016]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] xenbus: prefer list_for_each()
From
Date
On 07/07/16 09:33, Jan Beulich wrote:
> ... over list_for_each_safe() when list modification if accompanied by
> breaking out of the loop.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>

Reviewed-by: Juergen Gross <jgross@suse.com>

> ---
> drivers/xen/xenbus/xenbus_dev_frontend.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- 4.7-rc6-xen.orig/drivers/xen/xenbus/xenbus_dev_frontend.c
> +++ 4.7-rc6-xen/drivers/xen/xenbus/xenbus_dev_frontend.c
> @@ -364,7 +364,7 @@ out:
>
> static int xenbus_write_watch(unsigned msg_type, struct xenbus_file_priv *u)
> {
> - struct watch_adapter *watch, *tmp_watch;
> + struct watch_adapter *watch;
> char *path, *token;
> int err, rc;
> LIST_HEAD(staging_q);
> @@ -399,7 +399,7 @@ static int xenbus_write_watch(unsigned m
> }
> list_add(&watch->list, &u->watches);
> } else {
> - list_for_each_entry_safe(watch, tmp_watch, &u->watches, list) {
> + list_for_each_entry(watch, &u->watches, list) {
> if (!strcmp(watch->token, token) &&
> !strcmp(watch->watch.node, path)) {
> unregister_xenbus_watch(&watch->watch);
>
>

\
 
 \ /
  Last update: 2016-07-07 15:21    [W:0.024 / U:0.768 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site