lkml.org 
[lkml]   [2016]   [Jul]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible
On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote:
> ... as being the simpler variant.
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> ---
> drivers/block/xen-blkfront.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c
> +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c
> @@ -1825,14 +1825,13 @@ again:
> }
> kfree(path);
> }
> - err = xenbus_printf(xbt, dev->nodename, "protocol", "%s",
> - XEN_IO_PROTO_ABI_NATIVE);
> + err = xenbus_write(xbt, dev->nodename, "protocol",
> + XEN_IO_PROTO_ABI_NATIVE);
> if (err) {
> message = "writing protocol";
> goto abort_transaction;
> }
> - err = xenbus_printf(xbt, dev->nodename,
> - "feature-persistent", "%u", 1);
> + err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");

AFAICT you forgot to replace xenbus_printf with xenbus_write here.

Roger.

\
 
 \ /
  Last update: 2016-07-07 12:21    [W:0.134 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site