Messages in this thread | | | Date | Thu, 7 Jul 2016 11:44:05 +0200 | From | Roger Pau Monne <> | Subject | Re: [PATCH] xen-blkfront: prefer xenbus_write() over xenbus_printf() where possible |
| |
On Thu, Jul 07, 2016 at 02:06:33AM -0600, Jan Beulich wrote: > ... as being the simpler variant. > > Signed-off-by: Jan Beulich <jbeulich@suse.com> > --- > drivers/block/xen-blkfront.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) > > --- 4.7-rc6-prefer-xenbus_write.orig/drivers/block/xen-blkfront.c > +++ 4.7-rc6-prefer-xenbus_write/drivers/block/xen-blkfront.c > @@ -1825,14 +1825,13 @@ again: > } > kfree(path); > } > - err = xenbus_printf(xbt, dev->nodename, "protocol", "%s", > - XEN_IO_PROTO_ABI_NATIVE); > + err = xenbus_write(xbt, dev->nodename, "protocol", > + XEN_IO_PROTO_ABI_NATIVE); > if (err) { > message = "writing protocol"; > goto abort_transaction; > } > - err = xenbus_printf(xbt, dev->nodename, > - "feature-persistent", "%u", 1); > + err = xenbus_printf(xbt, dev->nodename, "feature-persistent", "1");
AFAICT you forgot to replace xenbus_printf with xenbus_write here.
Roger.
| |