Messages in this thread Patch in this message | | | From | Fabio Estevam <> | Date | Wed, 6 Jul 2016 10:15:41 -0300 | Subject | Re: [PATCH] pinctrl: imx21: include linux/module.h |
| |
Hi Arnd,
On Wed, Jul 6, 2016 at 9:52 AM, Arnd Bergmann <arnd@arndb.de> wrote: > The pinctrl driver includes a device table, but the macro used for > declaring it is declared in a header that is not visible here: > > drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror] > MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match); > > This adds the missing include. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > Fixes: e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
I think the correct fix here would be:
--- a/drivers/pinctrl/freescale/pinctrl-imx21.c +++ b/drivers/pinctrl/freescale/pinctrl-imx21.c @@ -325,7 +325,6 @@ static const struct of_device_id imx21_pinctrl_of_match[] = { .compatible = "fsl,imx21-iomuxc", }, { } }; -MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
static struct platform_driver imx21_pinctrl_driver = { .driver = {
If you agree I can send a formal patch.
| |