Messages in this thread | | | Date | Tue, 5 Jul 2016 23:31:47 +0200 | From | Borislav Petkov <> | Subject | Re: [PATCH -v3 1/2] ratelimit: Extend to print suppressed messages on release |
| |
On Tue, Jul 05, 2016 at 10:53:55PM +0200, Christian Borntraeger wrote: > Yes, this is new in next. As far as I can see, the new message would only > appear if we would call ratelimit_state_exit. Correct? We do not call this - > I assume this is ok?
Right, the idea for the /dev/kmsg use case was to issue the suppressed count only when we release the ratelimit state.
> We really only want to reuse the rate limit base code (to avoid writing the same > code twice) and being in lib indicated that this can indeed be used outside > printk. > Now: your patch 1 would allow me to get rid of the messages completely > by setting the flag and by not calling ratelimit_state_exit. Which is probably > what we should do in our code.
Yeah, that should work for your usecase.
-- Regards/Gruss, Boris.
ECO tip #101: Trim your mails when you reply.
| |