Messages in this thread | | | Subject | Re: [PATCH 1/5] mmu: mark spte present if the x bit is set | From | Paolo Bonzini <> | Date | Tue, 5 Jul 2016 12:50:17 +0200 |
| |
On 05/07/2016 05:06, Wanpeng Li wrote: > 2016-06-29 4:49 GMT+08:00 Paolo Bonzini <pbonzini@redhat.com>: > [...] >> >> I think another way to write it is "(pte & 0xFFFFFFFFull) && >> !is_mmio_spte(pte)", since non-present/non-MMIO SPTEs never use bits > > I misunderstand it here, this will also treat -W- EPT SPTEs as present, right?
-W- EPT SPTEs are present but invalid. They should never happen unless they are MMIO SPTEs (in which case !is_mmio_spte(pte) will return true and the function will return false).
Paolo
> Regards, > Wanpeng Li > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >
| |