lkml.org 
[lkml]   [2016]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[tip:perf/core] perf probe: Add group name support
    Commit-ID:  8d993d96901f55d26e083390aae80fd02cbff7aa
    Gitweb: http://git.kernel.org/tip/8d993d96901f55d26e083390aae80fd02cbff7aa
    Author: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    AuthorDate: Fri, 1 Jul 2016 17:04:01 +0900
    Committer: Arnaldo Carvalho de Melo <acme@redhat.com>
    CommitDate: Mon, 4 Jul 2016 19:39:00 -0300

    perf probe: Add group name support

    Allow user to set group name for adding new event. Note that user must
    ensure that the group name doesn't conflict with existing group name
    carefully.

    E.g. Existing group name can conflict with other events. Especially,
    using the group name reserved for kernel modules can hide kernel
    embedded events when loading modules.

    Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
    Signed-off-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
    Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
    Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
    Cc: Hemant Kumar <hemant@linux.vnet.ibm.com>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Cc: Peter Zijlstra <peterz@infradead.org>
    Link: http://lkml.kernel.org/r/146736024091.27797.9471545190066268995.stgit@devbox
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/Documentation/perf-probe.txt | 10 ++++++----
    tools/perf/util/probe-event.c | 23 ++++++++++++++---------
    2 files changed, 20 insertions(+), 13 deletions(-)

    diff --git a/tools/perf/Documentation/perf-probe.txt b/tools/perf/Documentation/perf-probe.txt
    index 8d09173..7a258e9 100644
    --- a/tools/perf/Documentation/perf-probe.txt
    +++ b/tools/perf/Documentation/perf-probe.txt
    @@ -143,16 +143,18 @@ PROBE SYNTAX
    Probe points are defined by following syntax.

    1) Define event based on function name
    - [EVENT=]FUNC[@SRC][:RLN|+OFFS|%return|;PTN] [ARG ...]
    + [[GROUP:]EVENT=]FUNC[@SRC][:RLN|+OFFS|%return|;PTN] [ARG ...]

    2) Define event based on source file with line number
    - [EVENT=]SRC:ALN [ARG ...]
    + [[GROUP:]EVENT=]SRC:ALN [ARG ...]

    3) Define event based on source file with lazy pattern
    - [EVENT=]SRC;PTN [ARG ...]
    + [[GROUP:]EVENT=]SRC;PTN [ARG ...]


    -'EVENT' specifies the name of new event, if omitted, it will be set the name of the probed function. Currently, event group name is set as 'probe'.
    +'EVENT' specifies the name of new event, if omitted, it will be set the name of the probed function. You can also specify a group name by 'GROUP', if omitted, set 'probe' is used for kprobe and 'probe_<bin>' is used for uprobe.
    +Note that using existing group name can conflict with other events. Especially, using the group name reserved for kernel modules can hide embedded events in the
    +modules.
    'FUNC' specifies a probed function name, and it may have one of the following options; '+OFFS' is the offset from function entry address in bytes, ':RLN' is the relative-line number from function entry line, and '%return' means that it probes function return. And ';PTN' means lazy matching pattern (see LAZY MATCHING). Note that ';PTN' must be the end of the probe point definition. In addition, '@SRC' specifies a source file which has that function.
    It is also possible to specify a probe point by the source line number or lazy matching by using 'SRC:ALN' or 'SRC;PTN' syntax, where 'SRC' is the source file path, ':ALN' is the line number and ';PTN' is the lazy matching pattern.
    'ARG' specifies the arguments of this probe point, (see PROBE ARGUMENT).
    diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c
    index f81b5dd..0201f66 100644
    --- a/tools/perf/util/probe-event.c
    +++ b/tools/perf/util/probe-event.c
    @@ -1206,10 +1206,8 @@ static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev)
    bool file_spec = false;
    /*
    * <Syntax>
    - * perf probe [EVENT=]SRC[:LN|;PTN]
    - * perf probe [EVENT=]FUNC[@SRC][+OFFS|%return|:LN|;PAT]
    - *
    - * TODO:Group name support
    + * perf probe [GRP:][EVENT=]SRC[:LN|;PTN]
    + * perf probe [GRP:][EVENT=]FUNC[@SRC][+OFFS|%return|:LN|;PAT]
    */
    if (!arg)
    return -EINVAL;
    @@ -1218,11 +1216,19 @@ static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev)
    if (ptr && *ptr == '=') { /* Event name */
    *ptr = '\0';
    tmp = ptr + 1;
    - if (strchr(arg, ':')) {
    - semantic_error("Group name is not supported yet.\n");
    - return -ENOTSUP;
    - }
    + ptr = strchr(arg, ':');
    + if (ptr) {
    + *ptr = '\0';
    + if (!is_c_func_name(arg))
    + goto not_fname;
    + pev->group = strdup(arg);
    + if (!pev->group)
    + return -ENOMEM;
    + arg = ptr + 1;
    + } else
    + pev->group = NULL;
    if (!is_c_func_name(arg)) {
    +not_fname:
    semantic_error("%s is bad for event name -it must "
    "follow C symbol-naming rule.\n", arg);
    return -EINVAL;
    @@ -1230,7 +1236,6 @@ static int parse_perf_probe_point(char *arg, struct perf_probe_event *pev)
    pev->event = strdup(arg);
    if (pev->event == NULL)
    return -ENOMEM;
    - pev->group = NULL;
    arg = tmp;
    }

    \
     
     \ /
      Last update: 2016-07-05 13:01    [W:3.768 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site