Messages in this thread | | | Subject | Re: [PATCH] phy: fix error handling | From | Kishon Vijay Abraham I <> | Date | Mon, 4 Jul 2016 13:22:50 +0530 |
| |
Hi,
On Monday 04 July 2016 02:38 AM, Christophe JAILLET wrote: > I will resubmit in the coming days. > > return PTR_ERR(phy->clk); > should also be updated.
while at that, also fix your $subject to something like "phy: sun9i-usb: fix error handling"
Thanks Kishon
> > Best regards, > CJ > > Le 03/07/2016 à 07:55, Christophe JAILLET a écrit : >> This is likely that checking 'phy->hsic_clk' instead of 'phy->clk' is >> expected here. >> >> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> >> --- >> drivers/phy/phy-sun9i-usb.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/phy/phy-sun9i-usb.c b/drivers/phy/phy-sun9i-usb.c >> index ac4f31a..ff99eba 100644 >> --- a/drivers/phy/phy-sun9i-usb.c >> +++ b/drivers/phy/phy-sun9i-usb.c >> @@ -141,7 +141,7 @@ static int sun9i_usb_phy_probe(struct platform_device *pdev) >> } >> phy->hsic_clk = devm_clk_get(dev, "hsic_12M"); >> - if (IS_ERR(phy->clk)) { >> + if (IS_ERR(phy->hsic_clk)) { >> dev_err(dev, "failed to get hsic_12M clock\n"); >> return PTR_ERR(phy->clk); >> } > >
| |