Messages in this thread | | | Subject | Re: [PATCH] phy: rockhip-usb: use devm_add_action_or_reset() | From | Kishon Vijay Abraham I <> | Date | Mon, 4 Jul 2016 16:26:58 +0530 |
| |
On Monday 04 July 2016 03:04 AM, Heiko Stuebner wrote: > Am Sonntag, 3. Juli 2016, 22:01:06 schrieb Sudip Mukherjee: >> If devm_add_action() fails we are explicitly calling the cleanup to free >> the resources allocated. Lets use the helper devm_add_action_or_reset() >> and return directly in case of error, as we know that the cleanup function >> has been already called by the helper if there was any error. >> >> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> > > a nice new helper this devm_add_action_or_reset. > > Reviewed-by: Heiko Stuebner <heiko@sntech.de>
applied, thanks.
-Kishon
| |