lkml.org 
[lkml]   [2016]   [Jul]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v3 01/21] backports: move legacy and SmPL patch application into helper
    From
    Date
    On Tue, 2014-11-11 at 00:14 -0800, Luis R. Rodriguez wrote:
    > From: "Luis R. Rodriguez" <mcgrof@suse.com>
    >
    > This allows us to extend how backports uses patches for
    > different types of applications. This will later be used
    > for kernel integration support, for example.
    >
    > This should have no functional change.

    Obviously this patch was applied a long time ago, but you lied - it has
    a functional change:

    > +        if process.returncode != 0:
    > +            if not args.verbose:
    > +                logwrite("Failed to apply changes from %s" %
    > print_name)
    > +                for line in output:
    > +                    logwrite('> %s' % line)
    > +            raise Exception('Patch failed')

    vs.

    > -        if process.returncode != 0:
    > -            if not args.verbose:
    > -                logwrite("Failed to apply changes from %s" %
    > print_name)
    > -                for line in output:
    > -                    logwrite('> %s' % line)
    > -            return 2

    This had a major impact on the devel/git-tracker.py tool.

    johannes

    \
     
     \ /
      Last update: 2016-07-04 12:21    [W:4.250 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site