Messages in this thread | | | Date | Mon, 4 Jul 2016 09:34:15 +0900 | From | Wolfram Sang <> | Subject | Re: [PATCH v5 4/8] i2c: add support for ACPI reconfigure notifications |
| |
On Fri, Jul 01, 2016 at 11:19:08PM +0300, Octavian Purdila wrote: > This patch adds supports for I2C device enumeration and removal via > ACPI reconfiguration notifications that are send as a result of an > ACPI table load or unload operation. > > The code is very similar with the device tree reconfiguration code > with only small differences in the way we test and set the enumerated > state of the device: > > * the equivalent of device tree's OF_POPULATED flag is the > flags.visited field in the ACPI device and the following > wrappers are used to manipulate it: acpi_device_enumerated(), > acpi_device_set_enumerated() and acpi_device_clear_enumerated() > > * the device tree code checks of status of the OF_POPULATED flag to > avoid trying to create duplicate Linux devices in two places: once > when the controller is probed, and once when the reconfigure event > is received; in the ACPI code the check is performed only once when > the ACPI namespace is searched because this code path is invoked in > both of the two mentioned cases > > The rest of the enumeration handling is similar with device tree: when > the Linux device is unregistered the ACPI device is marked as not > enumerated; also, when a device remove notification is received we > check that the device is in the enumerated state before continuing > with the removal of the Linux device. > > Signed-off-by: Octavian Purdila <octavian.purdila@intel.com> > Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
It has Mika's ack already, but to make sure:
Acked-by: Wolfram Sang <wsa@the-dreams.de>
[unhandled content-type:application/pgp-signature] | |