lkml.org 
[lkml]   [2016]   [Jul]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [lustre-devel] staging: lustre: One function call less in class_register_type() after error detection
    From
    Date

    On Jul 28, 2016, at 1:53 AM, SF Markus Elfring wrote:

    >> This function is called several times during lustre module insert.
    >> Namely it's called 5 times for 5 types:
    >> osc, mdc, lov, lmv, mgc.
    >
    > Will any extra memory accesses matter for the successful execution
    > in this use case?

    I doubt it.

    In typical deployments outside of testing environment, this function is
    called 5 times every system boot and never again.

    >> It's not called any more than that, so it's not exactly a super hot-path function
    >> to overoptimize it, and the failure is presumed to never happen too
    >> (or the module would be non-functional).
    >
    > Did the assignment for the local variable "rc" with a well-known error code
    > influence the run-time characteristics in unwanted ways?
    > https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/tree/drivers/staging/lustre/lustre/obdclass/genops.c?id=6a5b99a46bedc2cfbba96dec6d255c4b90af9ff8#n140

    I am not sure what do you mean here.


    \
     
     \ /
      Last update: 2016-07-29 18:21    [W:4.093 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site