lkml.org 
[lkml]   [2016]   [Jul]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 0/8] drm/amdgpu: Fine-tuning for three function implementations
    On Mon, Jul 18, 2016 at 3:41 AM, Christian König
    <christian.koenig@amd.com> wrote:
    > Am 16.07.2016 um 16:33 schrieb SF Markus Elfring:
    >>
    >> From: Markus Elfring <elfring@users.sourceforge.net>
    >> Date: Sat, 16 Jul 2016 16:23:21 +0200
    >>
    >> Further update suggestions were taken into account after patches
    >> were applied from static source code analysis.
    >
    >
    > Small coding style nit pick on patch #7:
    >>
    >> - }
    >> + } else
    >> + temp_storage = NULL;
    >
    > When an "if" has "{" and "}" the else should also use them even when it is
    > only one line.
    >
    > With that fixed the whole series is Reviewed-by: Christian König
    > <christian.koenig@amd.com>, but as Walter Harms pointed out as well there
    > are a couple of other things we could make more as well.

    Applied the series except patch 2 was which already fixed by an earlier patch.

    Thanks!

    Alex

    >
    > Regards,
    > Christian.
    >
    >>
    >> Markus Elfring (8):
    >> Delete an unnecessary check before
    >> drm_gem_object_unreference_unlocked()
    >> Delete unnecessary checks before the function call "kfree"
    >> One function call less in amdgpu_cgs_acpi_eval_object() after error
    >> detection
    >> Delete a variable in amdgpu_cgs_acpi_eval_object()
    >> Delete an unnecessary variable initialisation in
    >> amdgpu_cgs_acpi_eval_object()
    >> Change assignment for a variable in amdgpu_cgs_acpi_eval_object()
    >> Change assignment for a buffer variable in phm_dispatch_table()
    >> Delete an unnecessary variable initialisation in phm_dispatch_table()
    >>
    >> drivers/gpu/drm/amd/amdgpu/amdgpu_cgs.c | 28
    >> ++++++++++------------
    >> drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 4 +---
    >> .../gpu/drm/amd/powerplay/hwmgr/functiontables.c | 12 ++++------
    >> 3 files changed, 19 insertions(+), 25 deletions(-)
    >>
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2016-07-28 18:41    [W:4.305 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site