Messages in this thread | | | Date | Thu, 28 Jul 2016 01:11:27 +0100 | From | Salah Triki <> | Subject | Re: [PATCH 2/3] befs: remove constant variable |
| |
On Fri, Jul 01, 2016 at 01:07:31AM +0100, Luis de Bethencourt wrote: > Use macro directly instead of via assigning it to an unchanging variable. > > Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com> > --- > fs/befs/linuxvfs.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c > index 6740b0d..a16421a 100644 > --- a/fs/befs/linuxvfs.c > +++ b/fs/befs/linuxvfs.c > @@ -211,7 +211,6 @@ befs_readdir(struct file *file, struct dir_context *ctx) > befs_off_t value; > int result; > size_t keysize; > - unsigned char d_type; > char keybuf[BEFS_NAME_LEN + 1]; > > befs_debug(sb, "---> %s name %pD, inode %ld, ctx->pos %lld", > @@ -236,8 +235,6 @@ more: > return 0; > } > > - d_type = DT_UNKNOWN; > - > /* Convert to NLS */ > if (BEFS_SB(sb)->nls) { > char *nlsname; > @@ -249,14 +246,14 @@ more: > return result; > } > if (!dir_emit(ctx, nlsname, nlsnamelen, > - (ino_t) value, d_type)) { > + (ino_t) value, DT_UNKNOWN)) { > kfree(nlsname); > return 0; > } > kfree(nlsname); > } else { > if (!dir_emit(ctx, keybuf, keysize, > - (ino_t) value, d_type)) > + (ino_t) value, DT_UNKNOWN)) > return 0; > } > ctx->pos++; > -- > 2.5.1 >
Acked-by: Salah Triki <salah.triki@gmail.com>
Thanx :) salah
| |