lkml.org 
[lkml]   [2016]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] fs: befs: check silent flag before logging error
On Wed, Jun 29, 2016 at 09:27:40PM +0100, Luis de Bethencourt wrote:
> Log error only when silent flag is not set.
>
> Fixes: dbe6460388bc ("fs/befs/linuxvfs.c: check silent flag before logging errors")
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
>
> Hi,
>
> Reading the backlog of latest patches to befs, I noticed that Salah's patch
> missed one call to befs_error() when setting all to only be used when the
> silent argument is false.
>
> Thanks,
> Luis
>
> fs/befs/linuxvfs.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/fs/befs/linuxvfs.c b/fs/befs/linuxvfs.c
> index b700645..bf5658d 100644
> --- a/fs/befs/linuxvfs.c
> +++ b/fs/befs/linuxvfs.c
> @@ -790,7 +790,8 @@ befs_fill_super(struct super_block *sb, void *data, int silent)
> */
> blocksize = sb_min_blocksize(sb, 1024);
> if (!blocksize) {
> - befs_error(sb, "unable to set blocksize");
> + if (!silent)
> + befs_error(sb, "unable to set blocksize");
> goto unacquire_priv_sbp;
> }
>
> --
> 2.5.1
>

Acked-by: Salah Triki <salah.triki@gmail.com>

regards,
salah

\
 
 \ /
  Last update: 2016-07-28 02:41    [W:0.296 / U:0.080 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site