lkml.org 
[lkml]   [2016]   [Jul]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 6/6] spi: octeon: Add thunderx driver
    On 07/27/2016 11:12 AM, Mark Brown wrote:
    > On Mon, Jul 25, 2016 at 09:31:15AM -0700, David Daney wrote:
    >> On 07/25/2016 09:16 AM, Mark Brown wrote:
    >
    >>> The usual pattern would be something like (ARCH_THUNDER || COMPILE_TEST)
    >>> && PCI && 64BIT (so that people on other platforms where the device will
    >>> never actually appear don't get bothered by the prompt).
    >
    >> ARCH_THUNDER needs to die, so perhaps it should be (ARM64 || COMPILE_TEST)
    >> && PCI && 64BIT if you really want to hide it from non-arm64 kernel configs.
    >
    > It does? Why?

    It adds clutter. If we build a generic kernel, we first must select all
    the ARCH_*, then go back and select the devices we want. Not much of a
    value add.

    Better to just directly select the devices and remove this middle ARCH_*
    layer.

    Also who is responsible for making sure the proper ARCH_* constraints
    are maintained? If we remove ARCH_THUNDER, no need to worry about this.


    > One of the functions of the vendor specific Kconfig
    > options is to improve UX when configuring the kernel, if you're building
    > for a particular SoC or set of SoCs then we can avoid showing you
    > drivers that can never possibly appear in your system which makes life
    > a bit easier. We shouldn't be using them in the code itself but they do
    > help people in Kconfig.
    >

    \
     
     \ /
      Last update: 2016-07-27 21:01    [W:2.732 / U:0.300 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site