Messages in this thread | | | Date | Wed, 27 Jul 2016 17:27:57 +0800 | From | Peter Chen <> | Subject | Re: [PATCH] usb: gadget: remove redundant self assignment |
| |
On Mon, Jul 25, 2016 at 10:57:36PM +0100, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The assignment ret = ret is redundant and can be removed. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/usb/gadget/udc/core.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c > index ff8685e..48cf1a3 100644 > --- a/drivers/usb/gadget/udc/core.c > +++ b/drivers/usb/gadget/udc/core.c > @@ -107,10 +107,8 @@ int usb_ep_enable(struct usb_ep *ep) > goto out; > > ret = ep->ops->enable(ep, ep->desc); > - if (ret) { > - ret = ret; > + if (ret) > goto out; > - } > > ep->enabled = true; >
Reviewed-by: Peter Chen <peter.chen@nxp.com>
--
Best Regards, Peter Chen
| |