lkml.org 
[lkml]   [2016]   [Jul]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [alsa-devel] [PATCH v2] clkdev: add devm_of_clk_get()
    Date
    Hi Rob, Michael, Russell
    Cc Rob

    What is the conclusion of this patch ?
    We shouldn't add devm_of_clk_get() ? or I can continue ?

    > Thank you for your feedback
    >
    > > > struct clk *clk_get(struct device *dev, const char *con_id)
    > > > {
    > > > ...
    > > > if (dev) {
    > > > clk = __of_clk_get_by_name(dev->of_node, dev_id, con_id);
    > > > ~~~~~~~~~~~~
    > > > ...
    > > > }
    > > > }
    > > >
    > > > I would like to select specific device_node.
    > >
    > > Do you have access to the struct device that you want to target? Can you
    > > pass that device into either clk_get or devm_clk_get?
    >
    > If my understanding was correct, I think I can't.
    > In below case, "sound_soc" has its *dev, but "cpu" and "codec" doesn't
    > have *dev, it has node only. Thus, we are using of_clk_get() for these now.
    >
    > clk = of_clk_get(cpu, xxx);
    > clk = of_clk_get(codec, xxx);
    >
    > sound_soc {
    > ...
    > cpu {
    > ...
    > => clocks = <&xxx>;
    > };
    > codec {
    > ...
    > => clocks = <&xxx>;
    > };
    > };
    > _______________________________________________
    > Alsa-devel mailing list
    > Alsa-devel@alsa-project.org
    > http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

    \
     
     \ /
      Last update: 2016-07-27 03:21    [W:3.977 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site