Messages in this thread | | | From | Scott Wood <> | Date | Mon, 25 Jul 2016 02:05:27 -0500 | Subject | Re: [PATCH v2] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe |
| |
On Mon, 2016-07-25 at 06:15 +0000, Qiang Zhao wrote: > On Thu, Jul 07, 2016 at 10:25PM , Jason Cooper <jason@lakedaemon.net> wrote: > > > > -----Original Message----- > > From: Jason Cooper [mailto:jason@lakedaemon.net] > > Sent: Thursday, July 07, 2016 10:25 PM > > To: Qiang Zhao <qiang.zhao@nxp.com> > > Cc: oss@buserror.net; tglx@linutronix.de; marc.zyngier@arm.com; linuxppc- > > dev@lists.ozlabs.org; linux-kernel@vger.kernel.org; Xiaobo Xie > > <xiaobo.xie@nxp.com> > > Subject: Re: [PATCH v2] irqchip/qeic: move qeic driver from > > drivers/soc/fsl/qe > > > > Hi Zhao Qiang, > > > > On Thu, Jul 07, 2016 at 09:23:55AM +0800, Zhao Qiang wrote: > > > > > > The driver stays the same. > > > > > > Signed-off-by: Zhao Qiang <qiang.zhao@nxp.com> > > > --- > > > Changes for v2: > > > - modify the subject and commit msg > > > > > > drivers/irqchip/Makefile | 1 + > > > drivers/{soc/fsl/qe => irqchip}/qe_ic.c | 0 drivers/{soc/fsl/qe => > > > irqchip}/qe_ic.h | 0 > > > drivers/soc/fsl/qe/Makefile | 2 +- > > > 4 files changed, 2 insertions(+), 1 deletion(-) rename > > > drivers/{soc/fsl/qe => irqchip}/qe_ic.c (100%) rename > > > drivers/{soc/fsl/qe => irqchip}/qe_ic.h (100%) > > Please merge the include file into the C file and rename to follow the > > naming > > convention in drivers/irqchip/. e.g. irq-qeic.c or irq-qe_ic.c. > > > > Once you have that, please resend the entire series with this as the first > > patch. > Sorry, I have no idea about "Include file", could you explain which file you > meant?
qe_ic.h
If nothing else is going to include that, then the contents can go directly into qe_ic.c.
-Scott
| |