Messages in this thread | | | Date | Mon, 25 Jul 2016 11:30:46 -0700 | From | Dmitry Torokhov <> | Subject | Re: [PATCH] Input-rmi_bus: Delete an unnecessary check before the function call "of_node_put" |
| |
On Sun, Jul 24, 2016 at 09:35:56AM +0200, SF Markus Elfring wrote: > From: Markus Elfring <elfring@users.sourceforge.net> > Date: Sun, 24 Jul 2016 07:37:23 +0200 > > The of_node_put() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Applied, thank you.
> --- > drivers/input/rmi4/rmi_bus.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/input/rmi4/rmi_bus.c b/drivers/input/rmi4/rmi_bus.c > index 253df96..a735806 100644 > --- a/drivers/input/rmi4/rmi_bus.c > +++ b/drivers/input/rmi4/rmi_bus.c > @@ -232,10 +232,7 @@ err_put_device: > void rmi_unregister_function(struct rmi_function *fn) > { > device_del(&fn->dev); > - > - if (fn->dev.of_node) > - of_node_put(fn->dev.of_node); > - > + of_node_put(fn->dev.of_node); > put_device(&fn->dev); > } > > -- > 2.9.2 >
-- Dmitry
| |