lkml.org 
[lkml]   [2016]   [Jul]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] scsi: Delete an unnecessary check before the function call "kfree"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sun, 24 Jul 2016 14:20:21 +0200

    The kfree() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/scsi/scsi.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/scsi/scsi.c b/drivers/scsi/scsi.c
    index 1f36aca..1794c0c 100644
    --- a/drivers/scsi/scsi.c
    +++ b/drivers/scsi/scsi.c
    @@ -864,8 +864,7 @@ retry_pg83:
    rcu_assign_pointer(sdev->vpd_pg83, vpd_buf);
    mutex_unlock(&sdev->inquiry_mutex);
    synchronize_rcu();
    - if (orig_vpd_buf)
    - kfree(orig_vpd_buf);
    + kfree(orig_vpd_buf);
    }
    }

    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-24 15:01    [W:4.022 / U:1.236 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site