lkml.org 
[lkml]   [2016]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 1/3] IB/mthca: Delete an unnecessary check before the function call "pci_dev_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Sat, 23 Jul 2016 10:05:12 +0200

    The pci_dev_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/infiniband/hw/mthca/mthca_reset.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/infiniband/hw/mthca/mthca_reset.c b/drivers/infiniband/hw/mthca/mthca_reset.c
    index 74c6a94..c521654 100644
    --- a/drivers/infiniband/hw/mthca/mthca_reset.c
    +++ b/drivers/infiniband/hw/mthca/mthca_reset.c
    @@ -279,8 +279,7 @@ good:
    }

    out:
    - if (bridge)
    - pci_dev_put(bridge);
    + pci_dev_put(bridge);
    kfree(bridge_header);
    kfree(hca_header);

    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-23 13:41    [W:4.089 / U:0.176 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site