lkml.org 
[lkml]   [2016]   [Jul]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}'
From
Date
On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote:
> From: Emoly Liu <emoly.liu@intel.com>

unrelated trivial notes:

> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h
[]
> @@ -33,9 +33,9 @@
>  
>  /* The persistent object (i.e. actually stores stuff!) */
>  #define ECHO_PERSISTENT_OBJID    1ULL
> -#define ECHO_PERSISTENT_SIZE     ((__u64)(1<<20))
> +#define ECHO_PERSISTENT_SIZE     ((__u64)(1 << 20))

This is generally an error-prone pattern as the cast is
done after the shift.

Perhaps better is using a specific type

#define ECHO_PERSISTENT_SIZE (1ULL << 20)

And lustre seems to use types with unnecessary __ prefixes.

\
 
 \ /
  Last update: 2016-07-23 20:01    [W:0.101 / U:0.380 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site