Messages in this thread | | | Subject | Re: [PATCH 12/15] staging/lustre: Add spaces preferred around that '{+,-,*,/,|,<<,>>,&}' | From | Joe Perches <> | Date | Sat, 23 Jul 2016 10:31:12 -0700 |
| |
On Sat, 2016-07-23 at 02:37 -0400, Oleg Drokin wrote: > From: Emoly Liu <emoly.liu@intel.com>
unrelated trivial notes:
> diff --git a/drivers/staging/lustre/lustre/obdecho/echo_internal.h b/drivers/staging/lustre/lustre/obdecho/echo_internal.h [] > @@ -33,9 +33,9 @@ > > /* The persistent object (i.e. actually stores stuff!) */ > #define ECHO_PERSISTENT_OBJID 1ULL > -#define ECHO_PERSISTENT_SIZE ((__u64)(1<<20)) > +#define ECHO_PERSISTENT_SIZE ((__u64)(1 << 20))
This is generally an error-prone pattern as the cast is done after the shift.
Perhaps better is using a specific type
#define ECHO_PERSISTENT_SIZE (1ULL << 20)
And lustre seems to use types with unnecessary __ prefixes.
| |