lkml.org 
[lkml]   [2016]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/4] GPU-DRM-Etnaviv: Delete unnecessary if statement in __etnaviv_gem_new()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 22 Jul 2016 16:45:22 +0200

    Move a return statement into a block for successful function execution.
    Omit a duplicate check for the local variable "ret" then at the end.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/etnaviv/etnaviv_gem.c | 6 +-----
    1 file changed, 1 insertion(+), 5 deletions(-)

    diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
    index 8eee742..851a8ba 100644
    --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
    +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
    @@ -661,13 +661,9 @@ static struct drm_gem_object *__etnaviv_gem_new(struct drm_device *dev,
    */
    mapping = obj->filp->f_mapping;
    mapping_set_gfp_mask(mapping, GFP_HIGHUSER);
    + return obj;
    }

    - if (ret)
    - goto fail;
    -
    - return obj;
    -
    fail:
    drm_gem_object_unreference_unlocked(obj);
    return ERR_PTR(ret);
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-22 18:21    [W:4.113 / U:1.808 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site