lkml.org 
[lkml]   [2016]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] drm/bridge: ps8622: Delete an unnecessary check before backlight_device_unregister()
    On Fri, Jul 22, 2016 at 8:54 AM, SF Markus Elfring
    <elfring@users.sourceforge.net> wrote:
    > From: Markus Elfring <elfring@users.sourceforge.net>
    > Date: Fri, 22 Jul 2016 14:45:51 +0200
    >
    > The backlight_device_unregister() function tests whether its argument
    > is NULL and then returns immediately.
    > Thus the test around the call is not needed.
    >
    > This issue was detected by using the Coccinelle software.
    >
    > Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

    Applied to drm-misc

    > ---
    > drivers/gpu/drm/bridge/parade-ps8622.c | 4 +---
    > 1 file changed, 1 insertion(+), 3 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/bridge/parade-ps8622.c b/drivers/gpu/drm/bridge/parade-ps8622.c
    > index 5cd8dd7..583b8ce 100644
    > --- a/drivers/gpu/drm/bridge/parade-ps8622.c
    > +++ b/drivers/gpu/drm/bridge/parade-ps8622.c
    > @@ -636,9 +636,7 @@ static int ps8622_remove(struct i2c_client *client)
    > {
    > struct ps8622_bridge *ps8622 = i2c_get_clientdata(client);
    >
    > - if (ps8622->bl)
    > - backlight_device_unregister(ps8622->bl);
    > -
    > + backlight_device_unregister(ps8622->bl);
    > drm_bridge_remove(&ps8622->bridge);
    >
    > return 0;
    > --
    > 2.9.2
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2016-07-22 18:01    [W:2.310 / U:0.212 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site