lkml.org 
[lkml]   [2016]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] drm/qxl: Delete an unnecessary check before drm_gem_object_unreference_unlocked()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 22 Jul 2016 14:14:54 +0200

    The drm_gem_object_unreference_unlocked() function tests whether
    its argument is NULL and then returns immediately.
    Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/qxl/qxl_display.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/qxl/qxl_display.c b/drivers/gpu/drm/qxl/qxl_display.c
    index ad42968..3aef127 100644
    --- a/drivers/gpu/drm/qxl/qxl_display.c
    +++ b/drivers/gpu/drm/qxl/qxl_display.c
    @@ -468,8 +468,7 @@ void qxl_user_framebuffer_destroy(struct drm_framebuffer *fb)
    {
    struct qxl_framebuffer *qxl_fb = to_qxl_framebuffer(fb);

    - if (qxl_fb->obj)
    - drm_gem_object_unreference_unlocked(qxl_fb->obj);
    + drm_gem_object_unreference_unlocked(qxl_fb->obj);
    drm_framebuffer_cleanup(fb);
    kfree(qxl_fb);
    }
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-22 15:01    [W:4.906 / U:0.532 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site