lkml.org 
[lkml]   [2016]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 07/19] x86/dumpstack: add IRQ_USABLE_STACK_SIZE define
    On Thu, Jul 21, 2016 at 2:21 PM, Josh Poimboeuf <jpoimboe@redhat.com> wrote:
    > For reasons unknown, the x86_64 irq stack starts at an offset 64 bytes
    > from the end of the page. At least make that explicit.

    This is a change in behavior -- see below. Please mention this in the
    changelog.

    >
    > FIXME: Can we just remove the 64 byte gap? If not, at least document
    > why.

    I have no clue.

    >
    > irq_stack_end = (unsigned long *)(per_cpu(irq_stack_ptr, cpu));
    > - irq_stack = (unsigned long *)(per_cpu(irq_stack_ptr, cpu) - IRQ_STACK_SIZE);
    > + irq_stack = (unsigned long *)(per_cpu(irq_stack_ptr, cpu) -
    > + IRQ_USABLE_STACK_SIZE);

    This is different.

    \
     
     \ /
      Last update: 2016-07-22 00:41    [W:3.644 / U:0.132 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site