Messages in this thread | | | Subject | Re: staging: ks7010: Delete unnecessary uses of the variable "retval" | From | SF Markus Elfring <> | Date | Thu, 21 Jul 2016 23:26:30 +0200 |
| |
>> Can you follow expectations around the proposed refactoring of any >> function implementations? > > I don't understand both questions. Maybe you need to give examples?
I suggest to try the following script (semantic patch for working with the Coccinelle software) out on the discussed source files.
@checking_function_calls_directly@ identifier checker, retval, work; expression list el; statement is, es; type rt; @@ rt checker(...) { <+... -retval = work(el); if ( - retval + work(el) ) is else es ...+> }
Do you find such a source code transformation useful?
Regards, Markus
| |