lkml.org 
[lkml]   [2016]   [Jul]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC PATCH v2 0/3] fix overlayfs locks and leases
From
Date
On Thu, 2016-07-21 at 15:53 +0200, Miklos Szeredi wrote:
> I've split out the writecount handling and changed it around so that
> underlying layers are consistent and yet leases work correctly on
> overlayfs.
>
> Also pushed to the tip of
>
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs-next
>
> Thanks,
> Miklos
> ---
>
> Miklos Szeredi (3):
>   locks: fix file locking on overlayfs
>   vfs: make argument of d_real_inode() const
>   vfs: do get_write_access() on upper layer of overlayfs
>
>  fs/locks.c              | 53 ++++++++++++++++++++++++++++---------------------
>  fs/namespace.c          |  2 +-
>  fs/open.c               | 17 +++++++++++++---
>  fs/overlayfs/super.c    |  2 +-
>  include/linux/dcache.h  |  5 +++--
>  include/linux/fs.h      | 16 +++++++++++++--
>  include/uapi/linux/fs.h |  1 +
>  7 files changed, 64 insertions(+), 32 deletions(-)
>

Looks pretty sane overall.

Also, when I mentioned accessing the writable layer in openwrt in the
last set, I forgot that you typically only do reads on it, so the
writecount wouldn't be affected in the case of accessing to do backups.
So, I'm not sure I had a legit objection to the earlier patch, but I
think this looks a little cleaner anyway:

Acked-by: Jeff Layton <jlayton@poochiereds.net>


\
 
 \ /
  Last update: 2016-07-21 23:01    [W:0.090 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site