Messages in this thread | | | Date | Thu, 21 Jul 2016 21:13:42 +0200 | From | Jean Delvare <> | Subject | Re: staging: ks7010: Rename jump labels |
| |
Hi Markus,
On Thu, 21 Jul 2016 17:37:52 +0200, SF Markus Elfring wrote: > > That being said... checkpatch does not complain about leading space > > before labels. Not even with --strict. So why are you mentioning it here? > > I remembered a warning like "INDENTED_LABEL" instead. > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/scripts/checkpatch.pl?id=92d21ac74a9e3c09b0b01c764e530657e4c85c49#n4326
"#goto labels aren't indented, allow a single space however"
Can't be clearer :-)
> How do you generally think about jump label renaming?
Renaming from "out0:", "out1:" etc to something meaningful, yes. Did you have anything else in mind?
-- Jean Delvare SUSE L3 Support
| |