lkml.org 
[lkml]   [2016]   [Jul]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] GPU-DRM-nouveau: Delete an unnecessary check before the function call "pci_dev_put"
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Wed, 20 Jul 2016 19:43:27 +0200

    The pci_dev_put() function tests whether its argument is NULL and then
    returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/gpu/drm/nouveau/nouveau_drm.c | 3 +--
    1 file changed, 1 insertion(+), 2 deletions(-)

    diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
    index 66c1280..7b09841 100644
    --- a/drivers/gpu/drm/nouveau/nouveau_drm.c
    +++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
    @@ -525,8 +525,7 @@ nouveau_drm_unload(struct drm_device *dev)
    nouveau_vga_fini(drm);

    nvif_device_fini(&drm->device);
    - if (drm->hdmi_device)
    - pci_dev_put(drm->hdmi_device);
    + pci_dev_put(drm->hdmi_device);
    nouveau_cli_destroy(&drm->client);
    return 0;
    }
    --
    2.9.2
    \
     
     \ /
      Last update: 2016-07-20 20:21    [W:6.381 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site